[ASC-169] fix checkbox group all selection #1761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 102 102
Lines 1939 1953 +14
Branches 528 532 +4
=======================================
+ Hits 1934 1948 +14
Misses 5 5 ☔ View full report in Codecov by Sentry. |
glenkurniawan-adslot
force-pushed
the
fix-checkboxgroupall-selection
branch
from
2ace265 to
da3caea
Compare
xiaofan2406
reviewed
Feb 27, 2024
glenkurniawan-adslot
force-pushed
the
fix-checkboxgroupall-selection
branch
4 times, most recently
from
b9ba510 to
5ba803c
Compare
glenkurniawan-adslot
force-pushed
the
fix-checkboxgroupall-selection
branch
from
5ba803c to
64b5e51
Compare
|
xiaofan2406
reviewed
Mar 11, 2024
glenkurniawan-adslot
force-pushed
the
fix-checkboxgroupall-selection
branch
from
64b5e51 to
16be0ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 102 102
Lines 1962 1976 +14
Branches 566 547 -19
=======================================
+ Hits 1957 1971 +14
Misses 5 5 ☔ View full report in Codecov by Sentry. |
|
xiaofan2406
approved these changes
Apr 18, 2024
glenkurniawan-adslot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):